fix: remove KOTS template functions from helmchart.yaml values#29
Merged
Conversation
EC v3 parses helmchart.yaml with a strict YAML parser before KOTS template functions are resolved, causing 'did not find expected key' on upgrade. Remove ConfigOption and ImagePullSecretName template calls — EC only needs name/chartVersion to locate the chart archive. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Switch from {{repl FunctionName "arg"}} to repl{{ FunctionName `arg`}}
syntax per Replicated docs
- Remove global.imagePullSecrets (not needed for ghcr.io images)
- Add builder section required for air gap support
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{repl ConfigOption "admin_secret"}},{{repl ConfigOption "site_name"}}, and{{repl ImagePullSecretName }}template function calls fromhelmchart.yamlimage.tag: 'repl{{ .VersionLabel }}'(Go-template style, not a KOTS function call)name/chartVersionto match the chart archive; value injection happens in the KOTS Admin Console flowWhy
EC v3 parses
helmchart.yamlwith a standard YAML parser before KOTS template functions are resolved. The{{repl FunctionName }}syntax made the file unparseable at that stage, causing:Test plan
did not find expected keyerror should be gone